Support UTF-8 SMS submission using UCS-2 - #21
Open
dormancygrace wants to merge 1 commit into
Open
Conversation
Encode non-ASCII UTF-8 input as UCS-2. Normalize leading plus signs in international numbers. Reject malformed input instead of submitting a broken PDU. Add deterministic ASCII and UCS-2 submit test vectors. Make the send path propagate encoding and modem errors.
Author
|
Hardware delivery follow-up: both UTF-8/UCS-2 test messages were confirmed received, not merely accepted by the modem. Tested on a physical Fibocom NL678 with two international destinations ( |
Owner
|
I will test it with our (Polish) diacritics and let you know how it works. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
+before semi-octet phone-number encoding and validate all destination digitsThis addresses the missing send-side support discussed in #12 and #14. ASCII messages keep the existing GSM-7 path.
Validation
make -C pdu_lib test+CMGS: 8The hardware test used the same Cyrillic text as the committed UCS-2 test vector.